Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build extra wheels #227

Merged
merged 15 commits into from
Oct 15, 2021
Merged

Build extra wheels #227

merged 15 commits into from
Oct 15, 2021

Conversation

asvetlov
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 15, 2021 •
edited
Loading

Codecov Report

Merging #227 (551af1f) into master (d354171) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #227   +/-   ##
=======================================
  Coverage   98.36%   98.36%           
=======================================
  Files           1        1           
  Lines          61       61           
  Branches        7        7           
=======================================
  Hits           60       60           
  Misses          1        1
Flag Coverage Δ
unit 96.72% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
frozenlist/__init__.py 98.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d354171...551af1f. Read the comment docs.

@asvetlov asvetlov temporarily deployed to release October 15, 2021 16:10 Inactive
@asvetlov asvetlov temporarily deployed to release October 15, 2021 16:58 Inactive
webknjaz
webknjaz reviewed Oct 15, 2021
View reviewed changes
setup.py Show resolved Hide resolved
webknjaz
webknjaz approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for those two minor suggestions.

@asvetlov asvetlov merged commit 5248837 into master Oct 15, 2021
@asvetlov asvetlov deleted the setup-wheels branch October 15, 2021 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

Assignees
No one assigned
Labels
bot:chronographer:provided
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asvetlov @webknjaz